Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove numa configure option from hwloc 2.5+ #19085

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Oct 26, 2023

(created using eb --new-pr)

Hwloc removed the libnuma dependency in 2.0.0 and with it the --enable-libnuma option

We could remove the numactl dependency as well but I didn't wanted to change it to much, just avoid the configure warning (unknown option). But libnuma seems to be used (sometimes?) in the tests: https://github.com/open-mpi/hwloc/blob/a1b939190938ac253d4ba27328445b61258320c8/config/hwloc_internal.m4#L424-L434, so numctl could be downgraded to a builddependency

Furthermore I restricted the changes to hwloc 2.5+ corresponding the GCC 11.2+ in our toolchains. The same change can be applied to the older ECs too if wanted.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 41 out of 41 (5 easyconfigs in total)
taurusi6605.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/Flamefire/bf8bd4ff78d5c564e63a75e3f1acc704 for a full test report.

@boegel boegel added the bug fix label Jan 4, 2024
@boegel boegel added this to the release after 4.9.0 milestone Jan 4, 2024
@boegel
Copy link
Member

boegel commented Jan 4, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19085 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19085 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12496

Test results coming soon (I hope)...

- notification for comment with ID 1876753130 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0e0e2193796e4dee0163fe4f7797906d for a full test report.

@boegel
Copy link
Member

boegel commented Jan 4, 2024

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3124.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/351ab3ee1ad6a8a02117f3e74ea9455d for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 4, 2024

Going in, thanks @Flamefire!

@boegel boegel merged commit 40859e3 into easybuilders:develop Jan 4, 2024
5 checks passed
@Flamefire Flamefire deleted the 20231026130254_new_pr_hwloc250 branch January 4, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants