support postinstallcmds for dataset easyblock#4138
Open
smoors wants to merge 1 commit into
Open
Conversation
smoors
changed the title
postinstallcmds for dataset easyblock
Contributor
Author
|
Test report by @smoors Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 10 secs) (1 easyconfigs in total) |
akesandgren
reviewed
May 19, 2026
| def post_processing_step(self): | ||
| """Add files to object_storage, remove duplicates, add symlinks""" | ||
|
|
||
| EasyBlock.post_processing_step(self) |
Contributor
There was a problem hiding this comment.
Are you sure this shouldn't be super().post_processing_step ... ?
Contributor
Author
There was a problem hiding this comment.
yes, the only thing the post_processing_step of the Binary block does is handling staged installation, which is not supported by the Dataset block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)