Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick Tcl/Tk lib directory correctly in R easyblock, may be either lib or lib64 #3072

Merged

Conversation

mboisson
Copy link
Contributor

tcl/tk is not always in lib folder, on gentoo it is in lib64, this commit tests it and picks the right one

@boegel boegel changed the title Picks tcl/tk lib directory correctly from lib or lib64 pick Tcl/Tk lib directory correctly in R easyblock, may be either lib or lib64 Jan 17, 2024
@boegel boegel added the bug fix label Jan 17, 2024
@boegel boegel added this to the release after 4.9.0 milestone Jan 17, 2024
@boegel
Copy link
Member

boegel commented Jan 17, 2024

@boegelbot please test @ generoso
EB_ARGS="--installpath /tmp/pr3072 R-4.3.2-gfbf-2023a.eb"

@boegelbot
Copy link

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3072 EB_ARGS="--installpath /tmp/pr3072 R-4.3.2-gfbf-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3072 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12645

Test results coming soon (I hope)...

- notification for comment with ID 1896064855 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jan 30, 2024

@boegelbot please test @ generoso
EB_ARGS="--installpath /tmp/pr3072 R-4.3.2-gfbf-2023a.eb"

@boegelbot
Copy link

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3072 EB_ARGS="--installpath /tmp/pr3072 R-4.3.2-gfbf-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3072 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12775

Test results coming soon (I hope)...

- notification for comment with ID 1917598376 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS R-4.3.2-gfbf-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/cfe477c1e12af34d93ad876f02a3c4b0 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit a74b937 into easybuilders:develop Jan 30, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants