Skip to content

Commit

Permalink
deprecate unknown configure args in ConfigureMake easyblock
Browse files Browse the repository at this point in the history
  • Loading branch information
Flamefire committed Oct 27, 2023
1 parent c1ae2e5 commit bf240f3
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions easybuild/easyblocks/generic/configuremake.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@
from easybuild.easyblocks import VERSION as EASYBLOCKS_VERSION
from easybuild.framework.easyblock import EasyBlock
from easybuild.framework.easyconfig import CUSTOM
from easybuild.tools.build_log import print_warning
from easybuild.tools.build_log import print_warning, EasyBuildError
from easybuild.tools.config import source_paths, build_option
from easybuild.tools.filetools import CHECKSUM_TYPE_SHA256, adjust_permissions, compute_checksum, download_file
from easybuild.tools.filetools import read_file, remove_file
from easybuild.tools.run import run_cmd
from easybuild.tools.run import check_log_for_errors, run_cmd

# string that indicates that a configure script was generated by Autoconf
# note: bytes string since this constant is used to check the contents of 'configure' which is read as bytes
Expand Down Expand Up @@ -324,6 +324,11 @@ def configure_step(self, cmd_prefix=''):
)

(out, _) = run_cmd(cmd, log_all=True, simple=False)
try:
check_log_for_errors(out, ['configure: WARNING: unrecognized options:'])
except EasyBuildError as err:
self.log.deprecated("Unknown arguments for configure used: %s" % err, '5.0')
print_warning("Unknown arguments for configure detected: %s" % err)

return out

Expand Down

0 comments on commit bf240f3

Please sign in to comment.