Modifier Variable Type #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murraycatto
requested review from
a team,
eballantine and
lluzak
and removed request for
a team
eballantine
approved these changes
Aug 26, 2025
murraycatto
force-pushed
the
mrd-715-modifier-drop-exposed-and-available-as-a-variable-type
branch
from
0cde41c to
ef7fb8e
Compare
The `modifier` variable type has been added to Canvas and can be used in site builder schemas. - Added `modifier` to `Canvas::Constants::PRIMITIVE_TYPES` - Created `Canvas::Validator::SchemaAttribute::Modifier` validator class - Supports `random` as a default value (similar to product/variant types) - Can be used as single values or arrays - Follows the same validation patterns as other Canvas variable types
murraycatto
force-pushed
the
mrd-715-modifier-drop-exposed-and-available-as-a-variable-type
branch
from
ef7fb8e to
2d405b3
Compare
|
@eballantine the failure was due to the gem not being updated in a while |
murraycatto
deleted the
mrd-715-modifier-drop-exposed-and-available-as-a-variable-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
modifiervariable type has been added toCanvas and can be used in site builder schemas.
modifiertoCanvas::Constants::PRIMITIVE_TYPESCanvas::Validator::SchemaAttribute::Modifiervalidator classrandomas a default value (similar to product/variant types)