fix: extend html validation to treat liquid tags and variables differ… #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ently We were previously replacing both of these with blanks, which was causing issues when liquid variables were used within HTML tags. This change keeps the blanks as normal for liquid tags, but replaces the content of any variables with 'x' instead.
eballantine
reviewed
Apr 25, 2025
| # First replace liquid tags with spaces | ||
| html = html.gsub(LIQUID_TAG) { |tag| " " * tag.size } | ||
| # Then replace liquid variables with x's | ||
| html.gsub(LIQUID_VARIABLE) { |var| "x" * var.size } |
There was a problem hiding this comment.
Nice! If we're no longer using LIQUID_TAG_OR_VARIABLE think we can drop L12?
eballantine
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the current HTML validation to treat liquid tags and variables differently.
We were previously replacing both of these with blanks, which was causing issues when liquid variables were used within HTML tags. We then replaced both with 'x's; however this is now causing issues with the liquid tags.
This change keeps the blanks as normal for liquid tags, but replaces the content of any variables with 'x' instead, which should deliver the result we're after.
For example
<a href="{{ optin_link.url }}" {% if optin_link.new_tab %}target="_blank" rel="noopener noreferrer"{% endif %}>becomes:
<a href="xxxxxxxxxxxxxxxxxxx" target="_blank" rel="noopener noreferrer" >