Move from buildkite to Github actions #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves our buildkite pipeline to a simple github action using Github hosted runners.
It seems like the word token is character in some versions of JSON here, we update the message check to not rely on this
tomchipchase
approved these changes
Mar 12, 2025
| copy_example_directory("vagabond") | ||
| subject.run | ||
| message = "unexpected token at 'This is an invalid custom type." | ||
| message_pattern = /Invalid JSON: .+ - \nunexpected \w+(?:: | at )'This is an invalid custom type\.\n'/ |
There was a problem hiding this comment.
I guess this is highlighting that we don't actually control this error message, its coming from the JSON parser. Should we just assert that there is an offense, and we parrot back the invalid content.
There was a problem hiding this comment.
Yeah exactly, I wasn't really sure what level of confidence we need here so just wanted to make the spec work, think we can look later if we need to lessen further but given its working now and we barely touch this I'll just leave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can kill Buildkite once and for all we need to migrate this app over to GH actions as well