Skip to content

Conversation

@lluzak
Copy link
Contributor

@lluzak lluzak commented Nov 7, 2024

Cause:

With ruby 3.1 there was outdated rubygems included which with never version of psych gem version was failing to install one of the gems.

https://github.com/easolhq/easol-canvas/actions/runs/11702680056 openstreetmap/openstreetmap-website#4364

Solution:

One of the way to fix that problem was to update in Github action rubygems, but I opted in for upgrading Ruby version itself which already comes with proper version of rubygems and is already used in main Easol app.

Also upgraded Rubocop's ruby target version to match Ruby version.

@CatalinaTudor CatalinaTudor self-assigned this Nov 7, 2024
@emilyworrall
Copy link
Contributor

how am I the author of that commit?!

Copy link
Contributor

@CatalinaTudor CatalinaTudor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't make act work locally for me so unfortunately I am not able to attest this is fixing the action but it seems to build and install ok for me locally 👍
Screenshot 2024-11-07 at 12 06 04
Screenshot 2024-11-07 at 12 06 10
Screenshot 2024-11-07 at 12 08 54

The only thing is we should probably also bump the version before merging

@CatalinaTudor
Copy link
Contributor

@lluzak lluzak requested a review from CatalinaTudor November 7, 2024 12:21
Copy link
Contributor

@CatalinaTudor CatalinaTudor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@emilyworrall
Copy link
Contributor

seriously though why am I committing

@lluzak
Copy link
Contributor Author

lluzak commented Nov 7, 2024

I think somehow related with you bumping version up

Cause:

With ruby 3.1 there was outdated rubygems included which with never
version of psych gem version was failing to install one of the gems.

https://github.com/easolhq/easol-canvas/actions/runs/11702680056
openstreetmap/openstreetmap-website#4364

Solution:

One of the way to fix that problem was to update in Github action
rubygems, but I opted in for upgrading Ruby version itself which already
comes with proper version of rubygems and is already used in main Easol
app.

Also upgraded Rubocop's ruby target version to match Ruby version.
@lluzak lluzak force-pushed the hotfix/fix-github-action branch from cb08d73 to 788e73c Compare November 7, 2024 12:36
@lluzak lluzak merged commit 1e4c4fe into main Nov 7, 2024
1 check passed
@lluzak lluzak deleted the hotfix/fix-github-action branch November 7, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants