Introduce Github Action for release phase #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lluzak
force-pushed
the
391-publish-easol-canvas-gem-automatically-when-release-is-being-created
branch
from
b4b8992 to
5f2215e
Compare
lluzak
force-pushed
the
391-publish-easol-canvas-gem-automatically-when-release-is-being-created
branch
2 times, most recently
from
a823cc9 to
3b57a9e
Compare
sgerrand
approved these changes
Apr 14, 2023
Comment on lines
+19
to
+26
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: "3.1" | ||
| bundler-cache: true | ||
|
|
||
| - run: bundle install | ||
| - run: bundle exec rspec | ||
| - run: bundle exec rubocop |
There was a problem hiding this comment.
Tiny nitpick and not a blocker at all, but you could probably run rspec and rubocop in parallel to this job and make the rake release[remote] job block and wait for them to complete? It's fine to do that as a follow-up.
There was a problem hiding this comment.
Will test it separately, currently it takes 30 seconds to run whole job, will check if spinning separate jobs and waiting for those will not extend it in time.
lluzak
force-pushed
the
391-publish-easol-canvas-gem-automatically-when-release-is-being-created
branch
from
3b57a9e to
54d33c0
Compare
Github Action will be trigger when user create Github release. It will run all checks on gem like tests and linter. At the end it will publish gem to Rubygems repository. It also includes updated README file with detail instructions.
lluzak
force-pushed
the
391-publish-easol-canvas-gem-automatically-when-release-is-being-created
branch
from
54d33c0 to
760552f
Compare
lluzak
deleted the
391-publish-easol-canvas-gem-automatically-when-release-is-being-created
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Action will be trigger when user create Github release. It will run all checks on gem like tests and linter.
At the end it will publish gem to Rubygems repository.
It also includes updated README file with detail instruction.
Steps: