Skip to content

Support limiting product options for variant type #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2023
Merged

Support limiting product options for variant type #46

merged 3 commits into from
Mar 20, 2023

Conversation

@sldblog
Copy link
Contributor

@sldblog sldblog commented Mar 17, 2023

Extends the type: variant schema to allow a new attribute, only_from, which will limit the product types available in the first variant dropdown.

Start First dropdown: products Second dropdown: variant and extras
image image ℹ️ Depends on choice in the first dropdown.

image

We want to allow creators to choose the relevant types of products for blocks using this type.

Example:

variants:
  group: content
  label: Select variants to feature
  type: variant
  array: true
  default:
    - random
    - random
    - random
  only_from:
    - experiences

Related to #43.

sldblog added 3 commits March 17, 2023 12:12
@sldblog
Extend variant type with "only_from" attribute
f1c055d 
The new attribute is

1. optional
2. has to be a non-empty array

The intent is to provide a way for creators and theme developers to
limit the available product options under the variant type to either
experiences or accommodation, as appropriate.

It is intentionally reusing Product::ALLOWED_RESTRICTIONS because it's
limiting the product options.
@sldblog
Use percent literals instead of quoting strings
db16a61
@sldblog
Bump minor version to 3.4.0
480dc2d 
(This is a new, non-breaking feature)
@sldblog
Copy link
Contributor Author

sldblog commented Mar 17, 2023

Enable specifying type selection on Variant variables

@sldblog sldblog changed the title Support limiting options for variant type Support limiting product options for variant type Mar 17, 2023
@sldblog sldblog requested review from a team, CatalinaTudor and eballantine and removed request for a team March 17, 2023 12:24
@ianmooney ianmooney self-assigned this Mar 17, 2023
ianmooney
ianmooney approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@ianmooney ianmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

eballantine
eballantine approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@eballantine eballantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one David!

@sldblog sldblog merged commit 189f31d into main Mar 20, 2023
@sldblog sldblog deleted the support-limiting-options-for-variant-type branch March 20, 2023 11:38
@sldblog sldblog mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianmooney ianmooney ianmooney approved these changes

@eballantine eballantine eballantine approved these changes

@CatalinaTudor CatalinaTudor Awaiting requested review from CatalinaTudor

Assignees

@ianmooney ianmooney

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sldblog @ianmooney @eballantine