Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing declarations for SCRIPT_BEFORE_REQUIRED and SCRIPT_AFTER_REQUIRED flags #177

Closed
skyArony opened this issue Feb 2, 2024 · 2 comments

Comments

@skyArony
Copy link
Contributor

skyArony commented Feb 2, 2024

The commits added by the #141 work as expected, but there is a lack of relevant declarations in action.yml, leading to:

  1. VS Code prompting Invalid action input 'SCRIPT_BEFORE_REQUIRED' and Invalid action input 'SCRIPT_AFTER_REQUIRED'
  2. GitHub Action execution displaying a warning: "Unexpected input(s) 'SCRIPT_BEFORE_REQUIRED', 'SCRIPT_AFTER_REQUIRED', valid inputs are ['SSH_PRIVATE_KEY', 'REMOTE_HOST', 'REMOTE_USER', 'REMOTE_PORT', 'SOURCE', 'TARGET', 'ARGS', 'SSH_CMD_ARGS', 'EXCLUDE', 'SCRIPT_BEFORE', 'SCRIPT_AFTER']".

Therefore, I have added the relevant declarations in the PR to fix this issue.

skyArony added a commit to skyArony/ssh-deploy that referenced this issue Feb 2, 2024
@skyArony skyArony changed the title Added declarations to action.yml for SCRIPT_BEFORE_REQUIRED and SCRIPT_AFTER_REQUIRED flags Missing declarations for SCRIPT_BEFORE_REQUIRED and SCRIPT_AFTER_REQUIRED flags Feb 2, 2024
easingthemes added a commit that referenced this issue Feb 18, 2024
fix: added the missing declarations #177
github-actions bot pushed a commit that referenced this issue Feb 18, 2024
## [5.0.2](v5.0.1...v5.0.2) (2024-02-18)

### Bug Fixes

* added the missing declarations [#177](#177) ([bb271fe](bb271fe))
* Fix default values used incorrectly. ([a1b383f](a1b383f))
@dgw
Copy link

dgw commented Feb 19, 2024

Shouldn't this be closed as completed after #178 was merged + a release went out with the fix?

@skyArony
Copy link
Contributor Author

release at v5.0.2

github-actions bot pushed a commit to ximplez/ssh-deploy that referenced this issue Apr 19, 2024
# 1.0.0 (2024-04-19)

### Bug Fixes

* [easingthemes#113](https://github.com/ximplez/ssh-deploy/issues/113) limit ssh script input ([5894f5e](5894f5e))
* [easingthemes#113](https://github.com/ximplez/ssh-deploy/issues/113) limit ssh script output ([59827af](59827af))
* [easingthemes#113](https://github.com/ximplez/ssh-deploy/issues/113) limit ssh script output - rebuild ([756a522](756a522))
* [easingthemes#118](https://github.com/ximplez/ssh-deploy/issues/118) check undefined default values ([f0c02fb](f0c02fb))
* [easingthemes#118](https://github.com/ximplez/ssh-deploy/issues/118) check undefined default values rebuild ([54f8b6c](54f8b6c))
* [easingthemes#120](https://github.com/ximplez/ssh-deploy/issues/120) check undefined data ([2fbb060](2fbb060))
* add assets to semantic-release git ([0867b12](0867b12))
* add branch instead of a version in a readme ([8218c8e](8218c8e))
* add compiled file ([627ac29](627ac29))
* add githubWorkspace as default source root ([3ef66d0](3ef66d0))
* Add info for Permission denied issue. ([845b578](845b578))
* Add manual inputs for e2e test ([8f71595](8f71595))
* add NPM token ([2197bc6](2197bc6))
* add package json auto updates ([ce56d75](ce56d75))
* add uuid for ssh scripts ([66f6e4b](66f6e4b))
* Add visible Rsync CMD for debugging ([91b6d28](91b6d28))
* added the missing declarations [easingthemes#177](https://github.com/ximplez/ssh-deploy/issues/177) ([bb271fe](bb271fe))
* change npm to public ([191c82d](191c82d))
* codeql build ([5e456a4](5e456a4))
* codeql yaml syntax update ([87ad671](87ad671))
* fix default source if empty ([9f191f4](9f191f4))
* fix default TARGET ([4d08634](4d08634))
* Fix default values used incorrectly. ([a1b383f](a1b383f))
* fix manual release action ([245b7a9](245b7a9))
* log buffer from rsync stdout ([8e19e0d](8e19e0d))
* Log rsync command ([85f4a96](85f4a96))
* minify dist ([87551c3](87551c3))
* move e2e tests to main branch ([0069fae](0069fae))
* move e2e tests typo branch name ([6d3554b](6d3554b))
* normalize line endings in SSH key for the underlying OS ([3f5d9aa](3f5d9aa))
* only=prod package json ([95f4dc8](95f4dc8))
* plugins versions ([2f40dde](2f40dde))
* readme update ([80a7f53](80a7f53)), closes [easingthemes#67](https://github.com/ximplez/ssh-deploy/issues/67)
* rebuild ([2169399](2169399))
* rebuild and update readme ([98025d6](98025d6))
* remove change npm to public ([3c36af7](3c36af7))
* replace i with ci ([50d1f57](50d1f57))
* semantic-release/npm update config ([40096bf](40096bf))
* trigger automated release ([4d8bbf0](4d8bbf0))
* Update changelog ([765f5ff](765f5ff))
* update ncc ([20a0cae](20a0cae))
* update npm package name ([9c4e411](9c4e411))
* update plugins ([b2adc00](b2adc00))
* update plugins ([a50a999](a50a999))
* update sub dependencies ([2a32c8d](2a32c8d))
* update v3 e2e test ([450bf42](450bf42))
* use main branch for e2e testes ([21451fe](21451fe))
* yaml step name ([5c13615](5c13615))
* 修复 ARGS 为空时导致 rsync 执行错误问题。 ([caaa95b](caaa95b))

* Merge pull request easingthemes#173 from jeromelachaud/main ([ac1908e](ac1908e)), closes [easingthemes#173](https://github.com/ximplez/ssh-deploy/issues/173)
* Merge pull request easingthemes#83 from easingthemes/feature/easingthemes#82-update-node-version ([76660a8](76660a8)), closes [easingthemes#83](https://github.com/ximplez/ssh-deploy/issues/83) [easingthemes/feature/easingthemes#82](https://github.com/easingthemes/feature//issues/82)

### Features

* add e2e tests ([40f855a](40f855a))
* Add multi source and multi target support ([73a65ec](73a65ec))
* add semantic-release-action ([ac3c9b5](ac3c9b5))
* add ssh port from VARs, fix package-lock ([808b002](808b002))
* Add SSH remote script support -  before and after rsync ([2cd8a82](2cd8a82))
* Add SSH_CMD_ARGS support ([51a0063](51a0063))

### Performance Improvements

* update default rsync options ([2be7efb](2be7efb))

### BREAKING CHANGES

* update to use nodeJS v20
* update to use nodeJS v20
* Default rsync options updated to speed up default deployments.
from `rltgoDzvO` to `-rlgoDzvc -i`
* update to use nodeJS v16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants