Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/GHA: Run Windows tests on windows-2019 instead of windows-2022 #654

Closed
wants to merge 1 commit into from

Conversation

amotl
Copy link
Member

@amotl amotl commented May 22, 2022

Might resolve those errors:

OSError: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions

Spotted at, for example, https://github.com/earthobservations/wetterdienst/runs/6542666944#step:7:611

See also actions/runner-images#4856.

Resolves those errors:

    OSError: [WinError 10013] An attempt was made to access a socket in
    a way forbidden by its access permissions
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #654 (4cbf6fc) into main (e2acc55) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   90.99%   90.73%   -0.26%     
==========================================
  Files          94       94              
  Lines        6274     6274              
  Branches      529      529              
==========================================
- Hits         5709     5693      -16     
- Misses        443      456      +13     
- Partials      122      125       +3     
Flag Coverage Δ
unittests 90.73% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wetterdienst/ui/explorer/library.py 69.23% <0.00%> (-30.77%) ⬇️
wetterdienst/ui/explorer/app.py 81.52% <0.00%> (-6.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2acc55...4cbf6fc. Read the comment docs.

@gutzbenj gutzbenj marked this pull request as ready for review May 23, 2022 17:00
@amotl
Copy link
Member Author

amotl commented Sep 3, 2022

I think the situation improved in the meanwhile, so there will be no need for this patch.

@amotl amotl closed this Sep 3, 2022
@amotl amotl deleted the amo/fix-windows-tests branch September 3, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant