Improve IRCELINE request handling robustness

earthobservations · May 20, 2019 · 8cebfe0 · 8cebfe0
1 parent f3ec903
commit 8cebfe0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -5,6 +5,7 @@ Luftdatenpumpe changelog
 
 in progress
 ===========
+- Improve IRCELINE request handling robustness
 
 
 2019-05-19 0.12.1

diff --git a/luftdatenpumpe/source/irceline.py b/luftdatenpumpe/source/irceline.py
@@ -8,6 +8,7 @@
 from datetime import datetime, timedelta
 from operator import itemgetter
 
+from requests import HTTPError
 from rfc3339 import rfc3339
 from munch import munchify, Munch
 from urllib.parse import urljoin
@@ -53,7 +54,18 @@ def send_request(self, endpoint=None, params=None):
         url = urljoin(self.uri, endpoint)
         log.debug(f'Requesting IRCELINE live API at {url}')
         params = params or {}
-        return self.session.get(url, params=params, timeout=self.timeout).json()
+
+        response = self.session.get(url, params=params, timeout=self.timeout)
+        if response.status_code != 200:
+            try:
+                reason = response.json()
+            except:
+                reason = 'unknown'
+            message = f'Request failed: {reason}'
+            log.error(message)
+            response.raise_for_status()
+
+        return response.json()
 
     def get_stations(self):
         """