PlotTester.assert_title_contains() will occasionally fail keywords with spaces

[nkorinek]

PlotTester.assert_title_contains() will occasionally fail keywords with spaces. This was discovered on a plot where the output of plot_tester.get_title() was ('', 'HW Plot 1: Lidar Max vs. InSitu Max Tree Height\nSan Joaquin Field Site') and the failed keywords list was ["SJ", "SJER", "San Joaquin"]. If the space is taken out of "San Joaquin" to make it "SanJoaquin" the test passes. It could be that we just don't allow keywords with spaces, but that should be documented if that's the case. If we do decide to allow spaces, I believe it will be a rather easy fix. @lwasser

[lwasser]

thanks @nkorinek !!! great catch. we should definitely allow spaces. that's super quirky. Can you make a reproducible example with some fake data to demonstrate this in this issue please? i will make an issue template at some point too!!

[nkorinek]

@lwasser here's the reproducible example! It's pretty easy to replicate. https://gist.github.com/nkorinek/89ecd26db987fbd10e270bd6ee52e2f0

[nkorinek]

As shown in the gist, this is broken for assert_axis_label_contains as well.

[nkorinek]

hey @ryla5068 just FYI I've started working on this issue.

[lwasser]

@nkorinek does this issue relate to the pr i just merged? #205 i'd like to close issues that we've resolved!! there are a lot of issues here!

[nkorinek]

@lwasser it does!