Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-aligned PSTR() #8

Merged
merged 2 commits into from
May 19, 2020
Merged

Allow non-aligned PSTR() #8

merged 2 commits into from
May 19, 2020

Conversation

s-hadinger
Copy link

Report PR esp8266/Arduino#7275, but preserved the __pstr__

earlephilhower
earlephilhower approved these changes May 7, 2020
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@earlephilhower
Copy link
Owner

I'll wait until the main Arduino PR gets merged in case we do something different for the UMM_INFO debug stuff.

earlephilhower
earlephilhower requested changes May 8, 2020
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the main core is approved again, please port that here so it doesn't get lost. Thx!

@s-hadinger
Copy link
Author

Change from main core is now reported here.

@earlephilhower earlephilhower merged commit 671fedd into earlephilhower:xtensa-2_2_0-lock-arduino May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-hadinger @earlephilhower