Do not require USB init variable for TinyUSB + FreeRTOS #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgerhardt
changed the title
Contributor
Author
|
This confirmed works for me and the original poster. The rationale is that TinyUSB init seems to be in-line and blocking in the core's main.cpp before, which is different to the USB init path taken for the other USB stack (that creates a new FreeRTOS task), so there's no need to wait for a non-existing parallel task to do USB init work and thus the variable can be ignored in the TinyUSB + FreeRTOS case (and NO_USB as before). Open for comments. |
earlephilhower
approved these changes
Nov 21, 2022
Owner
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
Thanks for working on this while I was away!
schkovich
pushed a commit
to schkovich/arduino-pico
that referenced
this pull request
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #977.