Add WebServer, WebServerSecure, HTTPUpdateServer, HTTPUpdateServerSecure #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insead of managing the WiFiServer/WiFiServerSecure in the same object as the HTTP handling, split them into separate objects. This lets HTTP and HTTPS servers work without templates or duplicating code. The HTTP block just gets a `WiFiClient*` and works with that to only do HTTP processing, while the upper object handles the appropriate server and client types.
earlephilhower
force-pushed
the
webserver
branch
from
ae8baa9 to
f882615
Compare
earlephilhower
force-pushed
the
webserver
branch
from
0791753 to
dc93959
Compare
Core could crash while Serial debugging was going on and prints were happening from LWIP/IRQ land and the main app.
earlephilhower
force-pushed
the
webserver
branch
2 times, most recently
from
c9faa3f to
b8160d6
Compare
earlephilhower
force-pushed
the
webserver
branch
2 times, most recently
from
aca2b84 to
b3577be
Compare
earlephilhower
changed the title
earlephilhower
force-pushed
the
webserver
branch
from
b3577be to
cb76fd0
Compare
earlephilhower
force-pushed
the
webserver
branch
from
cb76fd0 to
88b84d9
Compare
when send()ing a large buffer, the WebServer::send() call would actually convert that buffer into a String (i.e. duplicate it, and potential issues with embedded \0s in binary data). Make a simple override to send(size, len) to allow writing from the source buffer instead.
earlephilhower
force-pushed
the
webserver
branch
from
0756355 to
3ab360c
Compare
earlephilhower
force-pushed
the
webserver
branch
from
3ab360c to
e23148c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of the ESP32 web server, with a significant refactor to allow it to work with both HTTP as well as HTTPS connections.
Started pulling in the ESP8266 examples because they included the
WebServerSecureobject, but there seems to be a significant API difference between the ESP8266 and ESP32WebServeras to make it an unpleasant experience.TODO
arduino-picowill be almost feature complete for most users (no comment on bugs, of course)