Skip to content

Fixes for the ULP driver #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
earlephilhower merged 4 commits into from
Nov 23, 2020
Merged

Fixes for the ULP driver #340

earlephilhower merged 4 commits into from
Nov 23, 2020

Conversation

@Martin-Laclaustra
Copy link
Contributor

@Martin-Laclaustra Martin-Laclaustra commented Nov 23, 2020

Fixes for the ULP driver:

  • Fix the order of mono samples (each pair was swapped)
  • Remove comment on version and date (currently tracked within ESP8266Audio repo)
  • Added some usage instructions to the header file
  • Delete sample in buffer after being rendered (ULP) to avoid sound looping in the buffer at the end of playback

@Martin-Laclaustra Martin-Laclaustra changed the title Ulp dev Fixes for the ULP driver Nov 23, 2020
earlephilhower
earlephilhower reviewed Nov 23, 2020
View reviewed changes
@earlephilhower earlephilhower merged commit 1c548c8 into earlephilhower:master Nov 23, 2020
@Martin-Laclaustra Martin-Laclaustra mentioned this pull request Feb 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@earlephilhower earlephilhower earlephilhower left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Martin-Laclaustra @earlephilhower