This repository was archived by the owner on Apr 29, 2026. It is now read-only.
Improve packages sort dropdown readability#4
Open
ElliotBadinger wants to merge 1 commit into
Open
Conversation
Chrome on Linux renders the packages sort select popup from native form-control styling, so the closed control looked dark while opened options could inherit a light menu surface with low-contrast option text. Scope the fix to the package sort select by declaring a dark color scheme and explicit option colors that match the existing terminal palette. Constraint: pi-website has no local test script; verification is browser/runtime and static build based Rejected: Replace the native select with custom markup | too broad for a contrast-only issue Confidence: medium Scope-risk: narrow Directive: Keep native select verification browser-specific because option popup rendering varies by OS/browser Tested: blargh --in src --out /tmp/pi-website-build-check Tested: Chrome 147 Linux clean profile computed .pkg-sort and option colors as dark background with light text Tested: Sort select change handler still updates value to name with 1864 package cards Tested: Subagent review APPROVE and verifier PASS Not-tested: Firefox/Safari native select popup rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the packages page sort dropdown so Chrome/Linux renders the native select/options with the site dark palette instead of a light popup with low-contrast option text.
Related report: earendil-works/pi#3979
Why
The closed sort control is dark, but opening it in stock Chrome/Linux could show a white native menu with very light unselected option text. That makes the package catalog's primary sorting control hard to read.
Verification
blargh --in src --out /tmp/pi-website-build-check.pkg-sort/optionstyles are dark background with light text:selectColorScheme = darkselectBg = rgb(24, 24, 27)selectColor = rgb(250, 250, 250)optionBg = rgb(24, 24, 27)optionColor = rgb(250, 250, 250)namestill updates the value and leaves the package list populated.