Able to start webserver. #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plrenaudin
reviewed
Sep 18, 2018
plrenaudin
left a comment
plrenaudin
left a comment
There was a problem hiding this comment.
Checked out the PR locally and it doesn't work.
😞
Other things you should consider:
- Use prettier and eslint for code formatting / checking
- Setup less or sass css processors
- Will you do SSR or CSR? If you choose the later you can remove all the server related code and simplify your life quite a bit ;-). This would also impact your server hosting costs.
- Consider using Parcel if you find Webpack too daunting, it's a brilliant alternative for small/medium projects which requires no configuration for your use case
- Decide on the browser support strategy to setup Babel accordingly
You go Girl!
| "main": "index.js", | ||
| "scripts": { | ||
| "build": "webpack", | ||
| "build-babel": "npm run build-babel-server && npm run build-babel-client", |
There was a problem hiding this comment.
Why using babel instead of just webpack with babel-loader?
|
|
||
| test('should start and trigger a callback', async() => { | ||
| let promise = webServer.start() | ||
| await expect(promise).resolves.toBeUndefined() |
There was a problem hiding this comment.
What does those tests mean? Shouldn't it be something about checking that the promise fulfilled?
| @@ -0,0 +1,40 @@ | |||
| let path = require('path'); | |||
| }, | ||
| module: moduleObj, | ||
| plugins: [ | ||
| new HtmlWebPackPlugin({ |
| let path = require('path'); | ||
| let nodeExternals = require('webpack-node-externals'); | ||
| const moduleObj = { | ||
| loaders: [ |
There was a problem hiding this comment.
that's the old way of using webpack, check this for the rules set https://webpack.js.org/configuration/module/#rule-loaders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.