Datacache on batch func #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
eaglemoor
commented
Apr 3, 2023
eaglemoor
commented
- Use Key[K]/Keys[K] in BatchFunc and Loader for save original context
- Add DataCache[K, V] for wrap batchFunc and use cache on real data. It's need for use not in memory caches, like redis.
added 2 commits
April 3, 2023 02:39
korotin
reviewed
Apr 3, 2023
| // ///////////////////////////////////////////////// | ||
| // Tests | ||
| /////////////////////////////////////////////////// | ||
| // ///////////////////////////////////////////////// |
dataloader.go
Outdated
| func batchWithCache[K comparable, V any](ctx context.Context, batchfn BatchFunc[K, V], keys Keys[K], cache DataCache[K, V]) []*Result[V] { | ||
| result := make([]*Result[V], len(keys)) | ||
| reqKeys := make(Keys[K], 0, len(keys)) | ||
| keyMap := make(map[int]int, len(keys)) |
There was a problem hiding this comment.
А зачем мапка? У тебя же ключ - это индекс reqKeys, который монотонно и непрерывно возрастает, можно на слайс заменить.
Owner
Author
There was a problem hiding this comment.
Немного переделал код, map тут нужно для организации exist key, если из batchfn придет больше ключей, но со slice мы ляжем с паникой.
added 2 commits
April 4, 2023 17:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.