Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/process comments #27

Merged
merged 4 commits into from
May 10, 2022
Merged

Fix/process comments #27

merged 4 commits into from
May 10, 2022

Conversation

jelledouwe
Copy link
Contributor

Description

Rename overlay in eagerx_tutorials. Also, add more info in the notebooks and the exercises.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I have read the CONTRIBUTION guide (required).
  • I have used semantic commit messages such that my PR is semantic (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make codestyle (required).
  • I have checked the codestyle using make check-codestyle and make lint (required).
  • I have ensured make pytest passes. (required).

Note: we are using a maximum length of 127 characters per line

@jelledouwe jelledouwe requested a review from bheijden as a code owner May 10, 2022 18:12
@jelledouwe jelledouwe merged commit ab836c4 into master May 10, 2022
@jelledouwe jelledouwe deleted the fix/process_comments branch May 10, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant