Use channels and non-blocking Wait to fix a potential race. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The race will never happen in practice, but whatever. I like this. Fixes #14.
|
Want to try it on OSX before merging it? |
| } | ||
| n++ | ||
|
|
||
| case <-tick: |
There was a problem hiding this comment.
I used a ticker because the busy loop bothered me. Does this actually matter? The syscall is going to move the Go routine and park it on a new thread. That probably takes longer than the ticker in the first place, right?
There was a problem hiding this comment.
Also, 5ms is pretty quick. Should I make it longer if we decide to keep it?
|
We'll see how it goes. |
mccoyst
added a commit
that referenced
this pull request
Dec 31, 2014
Use channels and non-blocking Wait to fix a potential race.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race will never happen in practice, but whatever. I like this.
Fixes #14.