Prepare Monex 2.0.0 (for eXist 5+)#77
Merged
duncdrum merged 1 commit intoeXist-db:masterfrom Apr 24, 2019
Merged
Conversation
adamretter
approved these changes
Apr 15, 2019
duncdrum
requested changes
Apr 17, 2019
Contributor
duncdrum
left a comment
There was a problem hiding this comment.
see my other review: let's add semver-min and semver-max here as well
Set semver-min=5.0.0-RC6 and add release notes
Member
Author
|
@duncdrum I've now changed |
duncdrum
approved these changes
Apr 24, 2019
Contributor
duncdrum
left a comment
There was a problem hiding this comment.
Setting min.version should indeed be sufficient here
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in #73 (comment), this PR (1) includes all changes since the 0.9.17 release, (2) "lowers" the eXist dependency to 5.0.0-RC6, since the previous dependency on 5.0.0-SNAPSHOT prevented installation of monex on 5.0.0-RC* versions of eXist, and (3) establishes the 2.x line of development for monex, which will take place in the master branch (whereas the 1.x line will take place in the monex-1.x branch).
I selected RC6 because (a) Compilation failed when targeting any lower version, as demonstrated by the following error:
And (b) RC5 wasn't available in the maven repository used by monex, as demonstrated by the following build failure: