Prepare monex 1.0.0 release and new monex-1.x branch#76
Merged
duncdrum merged 2 commits intoeXist-db:monex-1.xfrom Apr 24, 2019
Merged
Prepare monex 1.0.0 release and new monex-1.x branch#76duncdrum merged 2 commits intoeXist-db:monex-1.xfrom
duncdrum merged 2 commits intoeXist-db:monex-1.xfrom
Conversation
This reverts commit a2c7227. # Conflicts: # expath-pkg.xml.tmpl
Contributor
|
I have now added 4.6.1 to the Nexus repo. |
Contributor
|
@joewiz If you want to change |
Contributor
|
@joewiz exist should now properly treat max-min ranges as inclusive on both 4.x and 5.x |
Contributor
|
@joewiz without changing the |
Member
Author
|
@duncdrum Got it! I've now changed |
duncdrum
approved these changes
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until issue below is resolved.
Update (2019-04-22): Thanks to @duncdrum, this PR is ok to merge now.
As proposed in #73 (comment), this PR establishes a new "monex-1.x" branch targeting eXist 4.x by reverting the change that assumed the eXist 5.x JMX format. This will allow us to publish at least one more release of monex, containing valuable fixes submitted since monex 0.9.17, for users of eXist 4.x.
While the result builds, it has a problem: the
expath-pkg.xmlproduced by the build routine needs to have asemver-max=4.99.0declaration in order to prevent installation of this package on eXist 5.x, i.e., to limit installation to eXist 4.x systems. However, maven produces the following:So this PR should not be merged until we find some way to get maven to output
semver-max=4.99.0for the eXist dependency.Really, of course, we should specify both
semver-max=4.99.0AND asemver-min=3.7.0-SNAPSHOT(that was the last value before 0.9.17 when we bumped the requirement to 5.0.0, but, unfortunately, until the bug I reported that prevents concurrent use ofsemver-minandsemver-maxis solved (see also fgeorges/expath-pkg-java#8), we can only use one of these declarations, so we must choose the most important one,semver-max.A side issue: I had expected to be able to specify eXist 4.6.1 in pom.xml, but I got this error during the
mvn package, so I switched it to 4.6.0:This suggests the eXist 4.6.1 artifacts aren't in the maven repository used by the monex pom.
But again, ultimately, we need to be able to produce
semver-max=4.99.0.