Conversation
Contributor
adamretter
commented
Jun 30, 2021
adamretter
commented
- Fixes some issues with the build process.
- Adds missing Java dependencies and updates versions for eXist-db 5.3.0.
- Adds and enforces correct license headers.
- Adds missing index.html back into the XAR.
….0. As identified by 'mvn dependency:analyze'
line-o
reviewed
Jun 30, 2021
Member
line-o
left a comment
line-o
left a comment
There was a problem hiding this comment.
Good stuff!
One minor suggestion.
| <includes> | ||
| <include>pom.xml</include> | ||
| <include>src/test/java/xquery/crypto/CryptoIT.java</include> | ||
| <!-- include>src/test/java/ro/kuberam/libs/java/crypto/TestUtils.java</include> |
Member
There was a problem hiding this comment.
I would remove code instead of commenting it out. It will stay in version control if we ever need to get back to it.
Member
There was a problem hiding this comment.
Sorry, Juri, GitHub didn't show me your comment until after I merged!
joewiz
approved these changes
Jun 30, 2021
Member
joewiz
left a comment
joewiz
left a comment
There was a problem hiding this comment.
Looks good! And I didn't realize we could generate HTML from Markdown and include the README as index.html in the package. This is going to benefit people who get the package from outside the repo. All good stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.