Conversation
|
Thank you, @chakl and @line-o! Is there a reason the PR is against the eXist-5.3.0 branch instead of master? Could you confirm what the minimum eXist compatible version is now? Also, once this is merged and published, do you recommend that we pull the "v5.3.0" version from the public repo? I recall this was known to be incompatible with eXist 5.x, despite its dependency declarations. http://exist-db.org/exist/apps/public-repo/packages/expath-crypto-exist-lib.html?eXist-db-min-version=4.4.0 |
|
Version 5.3.0 of the crypto lib was, despite not being built from this repository, overwritten with a package that was version 1.0.0 with its version bumped. |
| <attributes> | ||
| <attribute name="optional" value="true"/> | ||
| <attribute name="maven.pomderived" value="true"/> | ||
| <attribute name="test" value="true"/> |
There was a problem hiding this comment.
Eclipse Project files should not be in SCM. Can you remove them and also add appropriate rules to your .gitignore please?
There was a problem hiding this comment.
I do not really understand why this is worthy to block the merge of this PR.
As only one line was added (by @claudius108) it is clear that this file was in version control before.
|
This PR needs to be closed as its target branch is master and not existdb 5.3.0 |
|
Superseded by #37 |
crypto lib compatible with the coming version of eXist-db (5.3.0)
This version is built on top of the community project base but includes the latest changes and fixes made by @claudius108
Thanks to @chakl for tying up the loose ends.