-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various bugfixes and improvements #886
Conversation
Hold fire! Whilst I think this code is correct, it can occasionally cause a deadlock which I think was only unearthed because of a sync issue this code fixes. Therefore the deadlock issue lies elsewhere. I am investigating... Deadlock looks like:
|
No changes still in 3.x codebase... |
@adamretter reported a deadlock situation, which is a problem, and potentially hard to fix. for sure we can ping him on this PR.... |
We've got rid of deadlocks in 2.2, but we've put a lot of efforts into codebase 2.2 and like to see them in 3.x |
This is a rebase of the changes from #853
Closes #851
Closes #852
Closes #853
Thanks to @alebastrov for the original work.