Skip to content

Conversation

@dizzzz
Copy link
Member

@dizzzz dizzzz commented Jan 2, 2026

Make configuration code of the webDAV extension more simple and consistent.

As a bonus the jdom 1.x dependency is removed for 'production'. For tests it is is still needed.

Code has been improved mechanically a bit.

@dizzzz dizzzz requested a review from a team as a code owner January 2, 2026 16:31
@dizzzz dizzzz requested review from duncdrum, line-o and reinhapa January 2, 2026 16:40
@joewiz
Copy link
Member

joewiz commented Jan 3, 2026

A question, asked out of pure curiosity, total ignorance, and everlasting gratitude for your work on WebDAV in eXist: is there a reason that WebDAV configuration is stored in webdav.properties and not in conf.xml?

@dizzzz
Copy link
Member Author

dizzzz commented Jan 3, 2026

@joewiz that is a very valid question :-) I never thought about it, I think I added this file as a 'easy fix' a long time ago.

That said, I am not sure if extensions should be configured from conf.xml, shouldn't it be the core only?
what if I'd make a XAR of an extension, how to configure it then? #noIdeaYet

@adamretter
Copy link
Contributor

I added a mechanism to conf.xml years ago that allows you to specify a config for each module, maybe @dizzzz that could help you to move your config into there within the WebDAV section?

@dizzzz
Copy link
Member Author

dizzzz commented Jan 4, 2026

thnx @adamretter I know about the config section.

@joewiz
Copy link
Member

joewiz commented Jan 4, 2026

@dizzzz Ah! Interesting to consider how a jar-only .xar package could have an editable configuration. Perhaps it could (a) ship with a default configuration that would be instantiated without the presence of a config file, and (b) it could check for the presence of a config file on disk (or in /db/system). I suspect that storing the config on disk may have some benefits - namely, surviving database corruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants