Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test resource leaks introduced in https://github.com/eXist-db/exist/pull/5276 #5503

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Fix test resource leaks introduced in https://github.com/eXist-db/exist/pull/5276 #5503

merged 8 commits into from
Oct 21, 2024

Conversation

adamretter
Copy link
Contributor

Fixes the resource leaks that were introduced in #5276

@adamretter adamretter added the bug issue confirmed as bug label Oct 20, 2024
@adamretter adamretter added this to the eXist-7.0.0 milestone Oct 20, 2024
@adamretter adamretter requested a review from a team as a code owner October 20, 2024 11:35
@adamretter adamretter removed the request for review from a team October 20, 2024 11:35
@adamretter adamretter mentioned this pull request Oct 20, 2024
Merged
@adamretter adamretter mentioned this pull request Oct 20, 2024
Merged
dizzzz
dizzzz requested changes Oct 20, 2024
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surefire issues.... MVND related? --> isolated to windows tests

[exist-core] [INFO] Running org.exist.storage.RecoverXmlTest
Error: core] [ERROR] [SUREFIRE] std/in stream corrupted

@adamretter adamretter force-pushed the hotfix/enforce-defragmentation branch from 20e9555 to fe454e3 Compare October 20, 2024 18:26
@adamretter adamretter force-pushed the hotfix/enforce-defragmentation branch from 9b8006a to 0511869 Compare October 20, 2024 21:38
@adamretter
Copy link
Contributor Author

Surefire issues.... MVND related? --> isolated to windows tests

[exist-core] [INFO] Running org.exist.storage.RecoverXmlTest
Error: core] [ERROR] [SUREFIRE] std/in stream corrupted

@dizzzz I have appended some commits which I think now address the (unrelated to this PR) Windows CI issues.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dizzzz
dizzzz approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

reinhapa
reinhapa approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@reinhapa reinhapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only question I got is if only activating flight recorder using -XX:StartFlightRecording would have the same bad impact or if that is caused by the additonal parameters...

@adamretter
Copy link
Contributor Author

The only question I got is if only activating flight recorder using -XX:StartFlightRecording would have the same bad impact or if that is caused by the additonal parameters...

@reinhapa I am afraid I don't know the answer to that. Perhaps you would like to experiment with that in a follow-up PR? I would suggest running whatever experiments you have multiple times in the Windows CI, as it can be fickle ;-)

@dizzzz dizzzz merged commit bf48faa into eXist-db:develop Oct 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizzzz dizzzz dizzzz approved these changes

@reinhapa reinhapa reinhapa approved these changes

Assignees
No one assigned
Labels
bug issue confirmed as bug
Projects
None yet
Milestone
eXist-7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adamretter @dizzzz @reinhapa