Remove the last small dependency on Apache Xalan

[adamretter]

We can use the equivalent classes from Apache Xerces instead

[dizzzz]

In the unit tests we explicitly test for xalan 😬

[adamretter]

In the unit tests we explicitly test for xalan 😬

@dizzzz Okay no problem. I have updated the PR to address that as well.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[dizzzz]

interesting... java8 only

[dizzzz]

it looks the PR combines 2 PRs ?

[adamretter]

There is a runtime dependency on Xalan in the GeoTools libraries used by the Spatial Index. I have opened a PR to fix that here - GEOT-7284. Once GEOT-7284 is merged, and they release a version that includes that, we will need to update the Spatial Index to use a newer version of the GeoTools.

[adamretter]

it looks the PR combines 2 PRs ?

@dizzzz now fixed.

[reinhapa]

@adamretter seems there is no support for "namespace" feature: https://github.com/eXist-db/exist/actions/runs/3649983650/jobs/6165379878#step:4:13854

[adamretter]

@adamretter seems there is no support for "namespace" feature: https://github.com/eXist-db/exist/actions/runs/3649983650/jobs/6165379878#step:4:13854

@reinhapa Yup, that is addressed in my PR geotools/geotools#4141

[adamretter]

@dizzzz @reinhapa Okay so they released GeoTools 28.1 and I just updated this, so I am hopeful that assuming CI goes through okay, then it is now ready.

[dizzzz]

craps

[adamretter]

@dizzzz No problem. I have fixed that one now. However I have hit another one in GeoTools, I will need to send them a PR as they are not handling XML Namespaces in a manner that Saxon likes:

Caused by: org.xml.sax.SAXException: Parser configuration problem: namespace reporting is not enabled
	at net.sf.saxon.event.ReceivingContentHandler.getNodeName(ReceivingContentHandler.java:477)
	at net.sf.saxon.event.ReceivingContentHandler.startElement(ReceivingContentHandler.java:366)
	at org.geotools.xml.transform.QNameValidatingHandler.startElement(QNameValidatingHandler.java:61)
	at org.geotools.xml.transform.TransformerBase$ContentHandlerFilter.startElement(TransformerBase.java:367)
	at org.geotools.xml.transform.TransformerBase$TranslatorSupport._start(TransformerBase.java:822)

[adamretter]

Requires this second PR geotools/geotools#4186 to be merged to GeoTools, and then a new release of GeoTools.
After that we will need to update this PR for the new release of GeoTools that includes the above GeoTools PR.

[duncdrum]

@adamretter despite two approvals the upstream changes still need to get merged and released. And we need to get a ci run here before merging. I’ll convert this to draft in the interim. Changes look good in principal

[adamretter]

The PR geotools/geotools#4186 to GeoTools was merged a couple of weeks ago. We are now just waiting for a new release of GeoTools that includes that fix. Then we can bump the dependency version here and we will be good to go...

[dizzzz]

I think this is a minor issue....

[adamretter]

@dizzzz @reinhapa I updated it to the latest version of GeoTools (which now finally includes all the changes I sent them) - tests appear to pass - WOOOHOO :-)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[dizzzz]

nice work !

[adamretter]

Thank you so much @dizzzz - it took almost 2 years, but we finally got there! We are now Xalan free 🥳

[dizzzz]

Woooooohooo