make auto pairing optional for quotes and parens

[marmoure]

this PR introduce a new feature that allows to toggle auto pairing for quotas and parens
Fixes #117

This open source contribution to the eXide project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.

[marmoure]

@cmccrorie this needs review and testing

[cmccrorie]

@cmccrorie this needs review and testing

@marmoure I have taken a look at this and the option to enable and disable this with in Edit > autopair works. I have had no issue when testing this.

[joewiz]

@marmoure In my testing, toggling the new "Edit > autoPair" command does toggle the auto-pairing of single quotes, double quotes, and parentheses: ' " (. This is great! I have a couple of questions:

1. Reloading the page resets the current selection for the toggle, but the setting should be persistent across reloads of the application, and it should live in "Edit > Preferences" as a checkbox. Could you please move this setting into "Edit > Preferences" as a checkbox with the label "Auto-pair characters"?
2. With auto-pairing on, square and curly braces - [ { - are not auto-paired, but should be. Would it be easy/quick to extend the auto-pairing behavior to these characters?

Reminder to self: add a note about this new option to https://github.com/eXist-db/eXide/blob/develop/docs/docs.md (perhaps under "code completion"?) before releasing.

[marmoure]

thanks @joewiz sounds good
i ll take a look, for the braces i didn't change the original behavior when auto pair is on,would you like to do so?

[joewiz]

@marmoure Interesting! In my original note, I mentioned that square brackets were being auto-paired, but perhaps I was mistaken or the behavior changed in the meantime. (I see square brackets are auto-paired in the demo at https://ace.c9.io/.)

Yes, if it's not too much trouble, I think that in the XQuery context it's natural to have auto-pairing on these two characters - [ and {.

But if it looks complex, the PR is acceptable without extending auto-pairing to these characters.

Thanks!

[joewiz]

(I see other ace users have requested more configurable behavior regarding auto-pairing... ajaxorg/ace#4199.)

[marmoure]

@joewiz we can have that as a feature if needed
we can configure the wanted behavior in eXide

[marmoure]

@joewiz the autoPair is now in EDIT -> Preferences and it's persistent
doing it this way makes it enabled globally for all documents as per the previous approach it was document independent

[joewiz]

I can confirm that the auto-pair preference works as expected. It changes operations immediately and persists across reloads of eXide.

Could you fix the preference label? It should be "Auto-pair characters" rather than "auto pair".

[joewiz]

@marmoure GitHub is reporting a conflict in the PR.

[marmoure]

@joewiz can you give this one, a final spin and see the output

[joewiz]

@marmoure I see that when I enter [ or { the corresponding closing character is added, with the cursor going between the two characters, as expected. But when I hit the delete key to delete the opening character, both the opening and closing character should be deleted. This is the case with ', ", and ( pairs. Would it be possible to ensure the same behavior in the case of [ and {?

[marmoure]

@joewiz i ll try to copy the behavior from the double quotes, it's a nice suggestion

[joewiz]

Works perfectly!

[joewiz]

@marmoure Thank you!