Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] tighten controller security #639

Open
line-o opened this issue Jun 12, 2021 · 0 comments
Open

[suggestion] tighten controller security #639

line-o opened this issue Jun 12, 2021 · 0 comments

Comments

@line-o
Copy link
Member

line-o commented Jun 12, 2021

Is your feature request related to a problem? Please describe.

Since this is a core application bundled with existtdb it should follow security best practices.

Describe the solution you'd like

Instead of defaulting to allow any route on top of some explicitly handled ones, the controller should handle each allowed route explicitly and any other route should result in a specific error (eg. NotFound with HTTP status-code 404).

Here is the default route handling code in the controller.xql

else
<ignore xmlns="http://exist.sourceforge.net/NS/exist">
<cache-control cache="yes"/>
</ignore>

Describe alternatives you've considered

Switch to https://github.com/eeditiones/roaster which will ensure explicit route handling.
Not exposing this application on public servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant