Improvements to liveliness tests [6275] #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 29, 2019 11:51
…liness_Automatic_BestEffort tests
…od in TwoWriters_TwoReaders test
…TwoReaders_ManualByTopic
… TwoWriters_TwoReaders_ManualByParticipant
…ic_Automatic_Reliable and ManualByTopic_Automatic_BestEffort
…tomatic_BestEffort test, plus adding a missing mutex in LivelinessManager
raquelalvarezbanos
changed the title
|
Build status:
|
|
Build status:
|
|
Build status:
|
LuisGP
reviewed
Sep 5, 2019
LuisGP
approved these changes
Sep 5, 2019
LuisGP
pushed a commit
that referenced
this pull request
Sep 26, 2019
* Refs #6245 Replacing sleep_for with condition variable in UnmatchedWriter test * Refs #6233 Adjunsting times in Liveliness_Automatic_Reliable and Liveliness_Automatic_BestEffort tests * Refs #6245 Increasing lease duration and decreasing announcement period in TwoWriters_TwoReaders test * Refs #6245 Replacing sleep_for with condition variable in TwoWriters_TwoReaders_ManualByTopic * Refs #6245 Removing sleep_for and using condition variable instead in TwoWriters_TwoReaders_ManualByParticipant * Refs #6245 Replacing sleep_for with condition variable in AssertLivelinessParticipant * Refs #6245 Replacing sleep_for with condition variable in ManualByTopic_Automatic_Reliable and ManualByTopic_Automatic_BestEffort * Refs #6233 Adjunsting times in ShortLiveliness_ManualByParticipant_Automatic_BestEffort test, plus adding a missing mutex in LivelinessManager * Refs #6233 Adjunsting times in ShortLiveliness_ManualByParticipant_Reliable test * Refs #6233 Adjunsting times in ShortLiveliness_ManualByParticipant_BestEffort test * Refs #6233 Final changes before pushing branch * Refs #6233 Fixing warnings
raquelalvarezbanos
pushed a commit
that referenced
this pull request
Sep 27, 2019
* WLP improvements [6168] (#650) * Refs #6111 Improvements to WLP and fixes for ReaderQos and WriterQos * Refs #6111 Adding some logging to liveliness tests * Refs #6111 Adding cv for writer in tests * Refs #6111 Fix for liveliness message and PDP * Refs #6111 Fixing warning on linux * Refs #6111 Review suggestions * Refs #6111 Removing logging and replacing some more sleep_for with cvs * Refs #6111 Fixing warning about unused parameter # Conflicts: # include/fastrtps/rtps/builtin/discovery/participant/PDP.h # include/fastrtps/rtps/builtin/discovery/participant/PDPClient.h # include/fastrtps/rtps/builtin/discovery/participant/PDPServer.h # include/fastrtps/rtps/builtin/discovery/participant/PDPSimple.h # src/cpp/rtps/builtin/BuiltinProtocols.cpp # src/cpp/rtps/builtin/discovery/participant/PDP.cpp # src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp # src/cpp/rtps/builtin/discovery/participant/PDPServer.cpp # src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp # src/cpp/rtps/builtin/liveliness/WLP.cpp # src/cpp/rtps/writer/RTPSWriter.cpp # test/blackbox/BlackboxTestsLivelinessQos.cpp * Improvements to liveliness tests [6275] (#689) * Refs #6245 Replacing sleep_for with condition variable in UnmatchedWriter test * Refs #6233 Adjunsting times in Liveliness_Automatic_Reliable and Liveliness_Automatic_BestEffort tests * Refs #6245 Increasing lease duration and decreasing announcement period in TwoWriters_TwoReaders test * Refs #6245 Replacing sleep_for with condition variable in TwoWriters_TwoReaders_ManualByTopic * Refs #6245 Removing sleep_for and using condition variable instead in TwoWriters_TwoReaders_ManualByParticipant * Refs #6245 Replacing sleep_for with condition variable in AssertLivelinessParticipant * Refs #6245 Replacing sleep_for with condition variable in ManualByTopic_Automatic_Reliable and ManualByTopic_Automatic_BestEffort * Refs #6233 Adjunsting times in ShortLiveliness_ManualByParticipant_Automatic_BestEffort test, plus adding a missing mutex in LivelinessManager * Refs #6233 Adjunsting times in ShortLiveliness_ManualByParticipant_Reliable test * Refs #6233 Adjunsting times in ShortLiveliness_ManualByParticipant_BestEffort test * Refs #6233 Final changes before pushing branch * Refs #6233 Fixing warnings * Refs #6455 Fix WLP cherry picking with @raquelalvarezbanos guidance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.