Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21514] Make Fast DDS build compatible with gcc9 #5178

Merged
merged 21 commits into from
Sep 2, 2024
Merged

[21514] Make Fast DDS build compatible with gcc9 #5178

merged 21 commits into from
Sep 2, 2024

Conversation

paxifaer
Copy link
Contributor

@paxifaer paxifaer commented Aug 28, 2024 •
edited by JesusPoderoso
Loading

Description

Edit: Fix the problem that gcc-9 cannot compile. The code should take into account version compatibility issues. Now our vehicle communication domain controllers all use gcc-9 and g++-9. You should take this into consideration

Fixes: #5170
Fixes: #5150

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@paxifaer
Fix the problem that gcc-9 cannot compile
49c5089 
Signed-off-by: paxifaer <807128216@qq.com>
@paxifaer
Copy link
Contributor Author

It is related to #5170

@paxifaer
Copy link
Contributor Author

@MiguelCompany @EduPonz How do you consider this?

@paxifaer
Copy link
Contributor Author

@JesusPoderoso Can you help me approve?Because it need ci/cd.

@JesusPoderoso JesusPoderoso changed the title Fix the problem that gcc-9 cannot compile. The code should take into account version compatibility issues. Now our vehicle communication domain controllers all use gcc-9 and g++-9. You should take this into consideration. [21514] Make Fast DDS build compatible with gcc9 Aug 29, 2024
JesusPoderoso added a commit that referenced this pull request Aug 29, 2024
@JesusPoderoso
Refs #21514: Apply PR #5178 changes
455fde8 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Copy link
Contributor

JesusPoderoso commented Aug 29, 2024 •
edited
Loading

Hi @paxifaer, thanks for your contribution.
Our current CI pipelines don't work properly with external contributions.
I've replicated your fix in this branch, and added a commit to test it in Ubuntu 20.04 (in which gcc default version installed is 9). The CI results can be checked here.

JesusPoderoso added a commit that referenced this pull request Aug 29, 2024
@JesusPoderoso
Refs #21514: Apply PR #5178 changes
f684e5a 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso added a commit that referenced this pull request Aug 29, 2024
@JesusPoderoso
Refs #21514: Apply PR #5178 changes
03d4d72 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@paxifaer
Copy link
Contributor Author

paxifaer commented Sep 1, 2024

Will you merge into master?

JesusPoderoso

This comment was marked as resolved.

Sign in to view

paxifaer and others added 12 commits September 2, 2024 14:42
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.cpp
25c155b 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.cpp
f0b5f1c 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.cpp
04e09fb 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
aed5584 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.cpp
c21add0 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
a8165f5 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
1588b5c 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
2aa5a59 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
b00bf87 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.cpp
4e66548 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.cpp
4ffc97f 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
213cf15 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer
Copy link
Contributor Author

paxifaer commented Sep 2, 2024

Your way of submitting code is very cool! But I don't know if I am doing it correctly, please help me check it.

@JesusPoderoso
Copy link
Contributor

There are still some missing suggestions to be applied @paxifaer.
Thanks for your effort!

paxifaer and others added 5 commits September 2, 2024 15:01
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.cpp
8a01b7c 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.cpp
f179049 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
07e3fe2 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
1cc148c 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
fd39d84 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
@paxifaer @JesusPoderoso
Update src/cpp/fastdds/xtypes/dynamic_types/AnnotationDescriptorImpl.hpp
6516552 
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
paxifaer
paxifaer commented Sep 2, 2024
View reviewed changes
Copy link
Contributor Author

@paxifaer paxifaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass

@paxifaer
Copy link
Contributor Author

paxifaer commented Sep 2, 2024

Thank you very much for your suggestions, then I added some more based on this. And it has been compiled and verified locally.

JesusPoderoso
JesusPoderoso approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manual CI passed

@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Sep 2, 2024
@MiguelCompany MiguelCompany merged commit a40b229 into eProsima:master Sep 2, 2024
3 checks passed
@paxifaer paxifaer deleted the gcc_9_compile branch September 7, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compile error Fast-DDS make error: static assertion failed
3 participants
@paxifaer @JesusPoderoso @MiguelCompany