Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid auto-linkage using cmake [16415] #3133

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Avoid auto-linkage using cmake [16415] #3133

merged 3 commits into from
Jun 21, 2023

Conversation

richiware
Copy link
Member

@richiware richiware commented Dec 3, 2022 •
edited by EduPonz
Loading

Description

Avoid auto-linkage in Windows through #pragma when the library was set through cmake.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #16246. Avoid auto-linkage using cmake
68b5414 
Signed-off-by: Ricardo González <correoricky@gmail.com>
@richiware richiware changed the title Avoid auto-linkage using cmake Avoid auto-linkage using cmake [16415] Dec 3, 2022
@richiware
Refs #16246. Fix usage of cmake generator expression
edb5c08 
Signed-off-by: Ricardo González <correoricky@gmail.com>
@JLBuenoLopez JLBuenoLopez added this to the v2.11.0 milestone Mar 16, 2023
EduPonz
EduPonz suggested changes Jun 20, 2023
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK except for a little NIT pick

@richiware
Refs #16246. Apply suggestion
2779848 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@EduPonz
Copy link

EduPonz commented Jun 20, 2023

@richiprosima please test this

@EduPonz EduPonz added the ci-pending PR which CI is running label Jun 20, 2023
@EduPonz
Copy link

EduPonz commented Jun 20, 2023

@richiprosima please test mac

1 similar comment
@EduPonz
Copy link

EduPonz commented Jun 21, 2023

@richiprosima please test mac

@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 21, 2023
@EduPonz EduPonz merged commit 5d9d340 into master Jun 21, 2023
@EduPonz EduPonz deleted the feature/avoid-auto-linkage branch June 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @EduPonz @JLBuenoLopez