Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15212] hotfix of BasicConfigurationExample cli #2951

Merged
merged 8 commits into from
Sep 28, 2022
Merged

[15212] hotfix of BasicConfigurationExample cli #2951

merged 8 commits into from
Sep 28, 2022

Conversation

MiguelBarro
Copy link
Contributor

@MiguelBarro MiguelBarro commented Sep 13, 2022 •
edited by EduPonz
Loading

Description

Fixing the specific use case where the first argument is a flag (like --transient).
In that case, the mechanism that checks if the first argument is publisher\subscriber failed.

The changes are piggybacked to DDSHelloWorldExample that uses the same parsing strategy.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelBarro MiguelBarro self-assigned this Sep 13, 2022
@MiguelBarro MiguelBarro marked this pull request as ready for review September 13, 2022 12:29
@MiguelBarro MiguelBarro requested a review from jparisu September 13, 2022 12:29
@MiguelBarro MiguelBarro added the no-test Skip CI tests if PR marked with this label label Sep 13, 2022
jparisu
jparisu suggested changes Sep 13, 2022
View reviewed changes
Miguel Barro added 2 commits September 14, 2022 11:31
Refs 15477. Minor fixes in BasicConfigurationExample
8023b95 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 15477. Piggiback cli changes to DDSHelloWorldExample
b138e4c 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro force-pushed the hotfix/examples/cli_parsing branch from 707e402 to b138e4c Compare September 14, 2022 09:33
Refs 15477. Addressing reviewer comments.
12af075 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
jparisu
jparisu previously approved these changes Sep 14, 2022
View reviewed changes
@juanlofer-eprosima juanlofer-eprosima mentioned this pull request Sep 22, 2022
Merged
13 tasks
juanlofer-eprosima
juanlofer-eprosima requested changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check numerical arguments are not negative.

Refs 15477. @juanlofer-eprosima requested a piggi-back. Range validat…
3469a62 
…ion of numeric arguments.

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 15477. Addressing future reviewer commits.
f5892f7 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro force-pushed the hotfix/examples/cli_parsing branch from 5e77240 to f5892f7 Compare September 22, 2022 14:07
Refs 15477. Fixing gcc warnings.
cbfae20 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 15477. Addressing reviewer commits.
3d3313c 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro force-pushed the hotfix/examples/cli_parsing branch from a863e3f to 3d3313c Compare September 23, 2022 07:35
@EduPonz EduPonz added this to the v2.8.0 milestone Sep 26, 2022
Refs 15477. Addressing more piggybacks
26194c1 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
juanlofer-eprosima
juanlofer-eprosima approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz
Copy link

EduPonz commented Sep 28, 2022

@richiprosima please test this

@EduPonz EduPonz added no-aarch Skip build & test for aarch64 ci-pending PR which CI is running labels Sep 28, 2022
@MRicoIE2CS
Copy link
Contributor

LGTM

@EduPonz EduPonz merged commit 2574c79 into master Sep 28, 2022
@EduPonz EduPonz deleted the hotfix/examples/cli_parsing branch September 28, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

@jparisu jparisu jparisu left review comments

Assignees

@MRicoIE2CS MRicoIE2CS

@MiguelBarro MiguelBarro

Labels
ci-pending PR which CI is running no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MiguelBarro @EduPonz @MRicoIE2CS @jparisu @juanlofer-eprosima