Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] #2470

juanlofer-eprosima · 2022-02-07T15:08:22Z

This PR closes #2299, closes #2289, closes #2409.

It may also be related to #2010, #2318, #2312, #1487.

Issues summary

Infinite loop [13540]: Disabling a TCP channel in the middle of a Receive call (invoked in perform_listen_operation) causes a hungup state.
Client shutdown [13718]:
-- Scenario: TCP client is launched before TCP server, and client is deleted also before server.
-- Issue: client stays in a hungup state until server is also deleted.
-- Expected: client gets fully removed without waiting for server's deletion.
Client reconnection [13721]: Publisher on TCP server -Subscriber client mismatch after reconnection from fastrtps tcp client to fastrtps tcp server. [13718] #2409

JLBuenoLopez · 2022-02-09T06:06:23Z

New test DDSCommunication_close_TCP_client is failing in Linux Ubuntu 20.04

EduPonz · 2022-02-09T06:40:36Z

@Mergifyio backport 2.4.x 2.3.x 2.1.x

mergify · 2022-02-09T06:40:53Z

backport 2.4.x 2.3.x 2.1.x

🟠 Waiting for conditions to match

merged [:pushpin: backport requirement]

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

…nnel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

JLBuenoLopez

LGTM

CI failures are unrelated

* Fix infinite loop in TCP header read Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add test for channel disconnection during TCP segment reception Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add issue reference Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs 13540: Unlock TCP client on shutdown Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs 13540: Update TCP sender resource channel on openning output channel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Add TCP client stuck test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add TCP client reconnection test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Link tests with issues Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Rename TCPChannelResource mock class Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 6639a84) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp

* Fix infinite loop in TCP header read Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add test for channel disconnection during TCP segment reception Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add issue reference Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs 13540: Unlock TCP client on shutdown Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs 13540: Update TCP sender resource channel on openning output channel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Add TCP client stuck test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add TCP client reconnection test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Link tests with issues Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Rename TCPChannelResource mock class Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 6639a84) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/dds/communication/CMakeLists.txt # test/unittest/transport/CMakeLists.txt

* Fix infinite loop in TCP header read Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add test for channel disconnection during TCP segment reception Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add issue reference Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs 13540: Unlock TCP client on shutdown Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs 13540: Update TCP sender resource channel on openning output channel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Add TCP client stuck test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add TCP client reconnection test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Link tests with issues Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Rename TCPChannelResource mock class Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 6639a84) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/dds/communication/CMakeLists.txt # test/dds/communication/PublisherModule.cpp # test/dds/communication/SubscriberModule.cpp # test/dds/communication/test_build.py # test/unittest/transport/CMakeLists.txt # test/unittest/transport/TCPv4Tests.cpp

mergify · 2022-02-10T14:37:24Z

backport 2.4.x 2.3.x 2.1.x

✅ Backports have been created

#2478 Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] (backport #2470) has been created for branch 2.4.x
#2479 Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] (backport #2470) has been created for branch 2.3.x
#2480 Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] (backport #2470) has been created for branch 2.1.x

* Fix infinite loop in TCP header read Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add test for channel disconnection during TCP segment reception Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add issue reference Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs 13540: Unlock TCP client on shutdown Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs 13540: Update TCP sender resource channel on openning output channel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Add TCP client stuck test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add TCP client reconnection test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Link tests with issues Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Rename TCPChannelResource mock class Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 6639a84) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Fix infinite loop in TCP header read Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add test for channel disconnection during TCP segment reception Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add issue reference Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs 13540: Unlock TCP client on shutdown Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs 13540: Update TCP sender resource channel on openning output channel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Add TCP client stuck test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add TCP client reconnection test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Link tests with issues Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Rename TCPChannelResource mock class Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 6639a84) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/dds/communication/CMakeLists.txt # test/unittest/transport/CMakeLists.txt Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Fix infinite loop in TCP header read Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add test for channel disconnection during TCP segment reception Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add issue reference Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs 13540: Unlock TCP client on shutdown Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs 13540: Update TCP sender resource channel on openning output channel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Add TCP client stuck test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add TCP client reconnection test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Link tests with issues Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Rename TCPChannelResource mock class Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 6639a84) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/dds/communication/CMakeLists.txt # test/dds/communication/PublisherModule.cpp # test/dds/communication/SubscriberModule.cpp # test/dds/communication/test_build.py # test/unittest/transport/CMakeLists.txt # test/unittest/transport/TCPv4Tests.cpp Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Fix TCP infinite loop, client shutdown and reconnection (#2470) * Fix infinite loop in TCP header read Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add test for channel disconnection during TCP segment reception Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add issue reference Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs 13540: Unlock TCP client on shutdown Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs 13540: Update TCP sender resource channel on openning output channel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Add TCP client stuck test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add TCP client reconnection test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Link tests with issues Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Rename TCPChannelResource mock class Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 6639a84) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/dds/communication/CMakeLists.txt # test/dds/communication/PublisherModule.cpp # test/dds/communication/SubscriberModule.cpp # test/dds/communication/test_build.py # test/unittest/transport/CMakeLists.txt # test/unittest/transport/TCPv4Tests.cpp Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #13540: fix conflicts Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: juanlofer-eprosima <88179026+juanlofer-eprosima@users.noreply.github.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Fix TCP infinite loop, client shutdown and reconnection (#2470) * Fix infinite loop in TCP header read Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add test for channel disconnection during TCP segment reception Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add issue reference Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs 13540: Unlock TCP client on shutdown Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs 13540: Update TCP sender resource channel on openning output channel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Add TCP client stuck test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add TCP client reconnection test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Link tests with issues Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Rename TCPChannelResource mock class Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 6639a84) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/dds/communication/CMakeLists.txt # test/unittest/transport/CMakeLists.txt Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #13540: fix conflicts Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #13540: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: juanlofer-eprosima <88179026+juanlofer-eprosima@users.noreply.github.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Fix TCP infinite loop, client shutdown and reconnection (#2470) * Fix infinite loop in TCP header read Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add test for channel disconnection during TCP segment reception Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add issue reference Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs 13540: Unlock TCP client on shutdown Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs 13540: Update TCP sender resource channel on openning output channel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Add TCP client stuck test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add TCP client reconnection test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Link tests with issues Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Rename TCPChannelResource mock class Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 6639a84) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #13540: fix conflicts Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #13540: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #13540: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: juanlofer-eprosima <88179026+juanlofer-eprosima@users.noreply.github.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

juanlofer-eprosima added this to the v2.5.1 milestone Feb 8, 2022

juanlofer-eprosima added the high-priority label Feb 8, 2022

juanlofer-eprosima and others added 10 commits February 10, 2022 08:16

Fix infinite loop in TCP header read

a582ef6

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

Add test for channel disconnection during TCP segment reception

23a1451

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

Apply suggestions

34420d2

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

Add issue reference

b54d772

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

Refs 13540: Unlock TCP client on shutdown

5aef86c

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

Refs 13540: Update TCP sender resource channel on openning output cha…

c7f6448

…nnel when reusing sender resource Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

Add TCP client stuck test

5f0e8a9

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

Add TCP client reconnection test

c77e089

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

Link tests with issues

b495dd7

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

Uncrustify

d3e25b7

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

juanlofer-eprosima force-pushed the bugfix/tcp_client_block branch from ebd4332 to d3e25b7 Compare February 10, 2022 07:19

juanlofer-eprosima changed the title ~~Fix TCP client stuck on shutdown [13540] & TCP client reconnection issue [13718]~~ Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] Feb 10, 2022

juanlofer-eprosima mentioned this pull request Feb 10, 2022

Fix infinite loop in TCP header read [13721] #2469

Closed

Rename TCPChannelResource mock class

f9808e2

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

JLBuenoLopez approved these changes Feb 10, 2022

View reviewed changes

JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Feb 10, 2022

MiguelCompany merged commit 6639a84 into master Feb 10, 2022

MiguelCompany deleted the bugfix/tcp_client_block branch February 10, 2022 14:35

mergify bot mentioned this pull request Feb 10, 2022

Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] (backport #2470) #2478

Merged

mergify bot mentioned this pull request Feb 10, 2022

Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] (backport #2470) #2479

Merged

mergify bot mentioned this pull request Feb 10, 2022

Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] (backport #2470) #2480

Merged

JLBuenoLopez mentioned this pull request Feb 11, 2022

[13832] Fix Windows warning #2487

Merged

jparisu mentioned this pull request Feb 28, 2022

TCP close without waiting channel closure #2255

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] #2470

Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] #2470

juanlofer-eprosima commented Feb 7, 2022 •

edited

Loading

JLBuenoLopez commented Feb 9, 2022

EduPonz commented Feb 9, 2022

mergify bot commented Feb 9, 2022 •

edited by MiguelCompany

Loading

JLBuenoLopez left a comment •

edited

Loading

mergify bot commented Feb 10, 2022

Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] #2470

Fix TCP infinite loop, client shutdown and reconnection [13540][13718][13721] #2470

Conversation

juanlofer-eprosima commented Feb 7, 2022 • edited Loading

JLBuenoLopez commented Feb 9, 2022

EduPonz commented Feb 9, 2022

mergify bot commented Feb 9, 2022 • edited by MiguelCompany Loading

🟠 Waiting for conditions to match

JLBuenoLopez left a comment • edited Loading

Choose a reason for hiding this comment

mergify bot commented Feb 10, 2022

✅ Backports have been created

juanlofer-eprosima commented Feb 7, 2022 •

edited

Loading

mergify bot commented Feb 9, 2022 •

edited by MiguelCompany

Loading

JLBuenoLopez left a comment •

edited

Loading