Include Shared Memory in the default transports. <2.0.x> [9726] #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
|
It would be great if someone launches a ROS2 CI against this PR. @jacobperron perhaps? |
MiguelCompany
changed the title
MiguelCompany
changed the title
|
Here you go:
|
|
Build status:
|
@jacobperron Thanks for this. Are the failures related to this PR? I see a lot of of them mentioning |
|
@MiguelCompany I'm pretty sure the test failures for connext are not related to the PR; Also I suspect the rclcpp.topic_statistics tests are unrelated. I'm not sure about the security tests failures on macOS and the rcl_action test failures on Windows. I'll retrigger CI with Fast-DDS only this time:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been several improvements and fixes on the Shared Memory transport, like #1329 and #1330, that made it more robust.
This PR adds this transport to the default ones.
Signed-off-by: Miguel Company MiguelCompany@eprosima.com