governance rules order <2.0.x> [9584] #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
requested changes
Oct 15, 2020
There was a problem hiding this comment.
This is still pending backport of tests and review from #1474
IkerLuengo
force-pushed
the
bugfix/governance-rules-order-2.0.x
branch
from
f95fb26
to
e993bc3
Compare
|
Build status:
|
IkerLuengo
force-pushed
the
bugfix/governance-rules-order-2.0.x
branch
from
e993bc3
to
7793e3f
Compare
|
Build status:
|
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
IkerLuengo
force-pushed
the
bugfix/governance-rules-order-2.0.x
branch
from
7793e3f
to
5218a4e
Compare
|
Build status:
|
MiguelCompany
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #1474 to 2.0.x
According to the standard, governance rules must be evaluated in order, and the first matching rule is applied.
We are using a map to store the rules before applying them, therefore, losing the original order.
Besides, the map object is never searched by key.
Changed the map for a vector.