Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Windows build: Use bare ${TINYXML2_LIBRARY} #1386

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Sep 11, 2020

Fixes #1385 caused by #1267

CI Windows building and testing only fastrtps Build Status

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Contributor Author

sloretz commented Sep 11, 2020

TODO undo ros2/ros2#1027 when this or another fix is merged

@MiguelCompany
Copy link
Member

Seems our CI does not want to automatically run on this one. I've manually launched it on windows (just a build without tests, as no code is affected)

Build Status

@MiguelCompany MiguelCompany merged commit c1c29b2 into eProsima:2.0.x Sep 12, 2020
@sloretz sloretz deleted the fix_windows_build_fail branch September 14, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants