-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle missing PID_PARTICIPANT_GUID for readers and writers [9296] #1382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (at least this is confirmed #1380 (comment))
and DDSI-RTPS v2.3
For optimization, implementations of the protocol shall not include a parameter in the Data submessage if it contains information that is redundant with other parameters already present in that same Data submessage. As a result of this optimization an implementation shall omit the serialization of the parameters listed in Table
9.10.
Reading DDSI-RTPS v2.3 once more, I am interpreting it the following way: Section 9.6.2.2 indicates that
It then says on Table 9.10 that Mapping of This means that field I have modified this PR to handle the case of a missing PID_PARTICIPANT_GUID and in that case default it to using the GUID prefix coming on PID_ENDPOINT_GUID and the default participant entity id |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Will take participant key from PID_ENDPINT_GUID when not. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
1ddae31
to
3819bf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MiguelCompany @richiware @IkerLuengo appreciate for the time in such short notice 😄 |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
* Handle missing PID_PARTICIPANT_GUID for readers and writers (#1382) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Leave correct default values on WriterQos::clear (#1384) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9302. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
When receiving EDP information of writers and readers, their participant key can be directly obtained from PID_ENDPOINT_GUID.
This PR ignores PID_PARTICIPANT_GUID on them.
Related to #1380
Signed-off-by: Miguel Company MiguelCompany@eprosima.com