Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 14, 2025

Description

The dependencies on ament_cmake, ament_cmake_gtest, and googletest-distribution are only needed when building for tests, so we should only inject them as test dependencies.

I've opened this against the 2.3.x branch (since that is what ROS 2 is currently using), but it probably should be backported to all branches.

@Mergifyio backport 2.2.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

This is an automatic backport of pull request #293 done by [Mergify](https://mergify.com).

The dependencies on ament_cmake, ament_cmake_gtest, and
googletest-distribution are only needed when building
for tests, so we should only inject them as test dependencies.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 88eb2ab)

# Conflicts:
#	colcon.pkg
@mergify mergify bot added the conflicts label Nov 14, 2025
@mergify
Copy link
Author

mergify bot commented Nov 14, 2025

Cherry-pick of 88eb2ab has failed:

On branch mergify/bp/1.0.x/pr-293
Your branch is up to date with 'origin/1.0.x'.

You are currently cherry-picking commit 88eb2ab.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   colcon.pkg

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v1.0.29 milestone Nov 14, 2025
@MiguelCompany MiguelCompany self-requested a review November 14, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants