Skip to content

Conversation

@jakewhelan
Copy link
Contributor

@jakewhelan jakewhelan commented Nov 20, 2020

Synopsis:

  • jspdf version in package.json is specified as ^1.4.1, 1.4.1 explicitly is locked in package-lock.json so this version is used for development.
  • Because of the way semver works, when installing html2pdf.js as a consumer npm is not resolving 1.4.1 it's resolving the latest minor version 1.5.3
  • jspdf@1.5.3 does something really nasty: imports a dependency directly from github.

Evidence:

Problem:

  • Personal: I'm not comfortable with this and I'm sure many others feel the same
  • My org: For security reasons, our CI does not allow dependencies that aren't proxied through our private registry
  • General: This makes the library not proxiable/replicatable in a private npm registry because the dependency exists outside of npm, which is a problem for more than just my org

Solution:
jspdf have already remedied this problem in 2.x.x, but rather than take on the cost of any potential breaking changes they've introduced I'm proposing we simply lock the version to 1.4.1. This way the jspdf version consumers use matches the one developers of this library use.

@eKoopmans
Copy link
Owner

Hi @jakewhelan, thank you very much for the contribution, sorry it's taken me so long to take any action. I've just incorporated this change into v0.9.3 - the change is already made, but I'll merge your PR anyway. Thanks again!

@eKoopmans eKoopmans merged commit 7c78308 into eKoopmans:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants