fix: set jspdf to 1.4.1 to avoid semver resolution of newer versions #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis:
jspdfversion inpackage.jsonis specified as^1.4.1,1.4.1explicitly is locked inpackage-lock.jsonso this version is used for development.html2pdf.jsas a consumer npm is not resolving1.4.1it's resolving the latest minor version1.5.3jspdf@1.5.3 does something really nasty: imports a dependency directly from github.Evidence:
Problem:
Solution:
jspdfhave already remedied this problem in2.x.x, but rather than take on the cost of any potential breaking changes they've introduced I'm proposing we simply lock the version to1.4.1. This way thejspdfversion consumers use matches the one developers of this library use.