Change Windows newline detection to occur on all platforms#320
Merged
jondegenhardt merged 1 commit intoeBay:masterfrom Oct 10, 2020
Merged
Conversation
This was referenced Oct 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the tsv-utils tools require Unix newlines. These tools check for Windows newlines on Posix platforms using
throwIfWindowsNewlineOnUnix. However, these tools generally have trouble with Windows newlines on Windows platforms as well. And, there is no warning to users. This adds detection and user messaging on Windows.The PR changes Windows newline detection to occur on all platforms. The
throwIfWindowsNewlineOnUnixwas renamed tothrowIfWindowsNewlineand the code changed to throw on all all platforms. Callers were changed to call the new function.This is a step towards getting a Window build that has a fully functioning test suite. See issue #317. Support for Windows newlines can be evaluated after having a fully functioning test suite on Windows.