Skip to content

Add max_receive_msg_size parameters.#230

Merged
hkadayam merged 2 commits into
eBay:masterfrom
xiaoxichen:msg_size
Mar 27, 2024
Merged

Add max_receive_msg_size parameters.#230
hkadayam merged 2 commits into
eBay:masterfrom
xiaoxichen:msg_size

Conversation

@xiaoxichen

Copy link
Copy Markdown
Contributor

max_receive_msg_size default to 4M, which might be too small for some usecases, allow this to be reconfigurable.

@raakella1
raakella1 requested a review from yamingk March 21, 2024 20:11
max_receive_msg_size default to 4M, which might be too small
for some usecases, allow this to be reconfigurable.

Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
Comment thread src/grpc/rpc_server.cpp
Comment thread include/sisl/grpc/rpc_server.hpp
Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #230 (dfacbfd) into master (c3b8844) will increase coverage by 63.70%.
The diff coverage is 66.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #230       +/-   ##
===========================================
+ Coverage        0   63.70%   +63.70%     
===========================================
  Files           0       72       +72     
  Lines           0     4405     +4405     
  Branches        0      555      +555     
===========================================
+ Hits            0     2806     +2806     
- Misses          0     1349     +1349     
- Partials        0      250      +250     
Components Coverage Δ
AuthManager 77.77% <ø> (∅)
Cache 25.23% <ø> (∅)
FDS 71.01% <ø> (∅)
FileWatcher 56.25% <ø> (∅)
Flip 65.34% <ø> (∅)
gRPC 77.04% <66.66%> (∅)
Logging 30.18% <ø> (∅)
Metrics 80.20% <ø> (∅)
Options 100.00% <ø> (∅)
Setting 56.79% <ø> (∅)
StatusObject 73.83% <ø> (∅)
Utility 82.71% <ø> (∅)
Version 95.83% <ø> (∅)

Comment thread src/grpc/rpc_client.cpp
Comment thread src/grpc/tests/function/echo_async_client.cpp
@hkadayam
hkadayam merged commit 370c772 into eBay:master Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants