Skip to content

Need to add -rdynamic to anything linking libsisl_logging.a#223

Merged
szmyd merged 1 commit into
eBay:masterfrom
szmyd:logging_fix
Feb 8, 2024
Merged

Need to add -rdynamic to anything linking libsisl_logging.a#223
szmyd merged 1 commit into
eBay:masterfrom
szmyd:logging_fix

Conversation

@szmyd

@szmyd szmyd commented Feb 8, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@szmyd
szmyd requested a review from raakella1 February 8, 2024 16:41
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #223 (c5c736e) into master (6dec7cd) will decrease coverage by 0.33%.
Report is 1 commits behind head on master.
The diff coverage is 40.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   63.75%   63.42%   -0.33%     
==========================================
  Files          72       72              
  Lines        4326     4331       +5     
  Branches      543      546       +3     
==========================================
- Hits         2758     2747      -11     
- Misses       1326     1340      +14     
- Partials      242      244       +2     
Components Coverage Δ
AuthManager 77.77% <ø> (ø)
Cache 25.23% <ø> (-3.02%) ⬇️
FDS 70.96% <ø> (+0.19%) ⬆️
FileWatcher 56.25% <ø> (ø)
Flip 65.34% <ø> (ø)
gRPC 76.68% <ø> (ø)
Logging 30.18% <25.00%> (+0.24%) ⬆️
Metrics 80.20% <ø> (ø)
Options 100.00% <ø> (ø)
Setting 56.79% <ø> (ø)
StatusObject 73.83% <ø> (ø)
Utility 82.71% <ø> (ø)
Version 95.83% <100.00%> (ø)

@szmyd
szmyd merged commit 4bc0ea8 into eBay:master Feb 8, 2024
@szmyd
szmyd deleted the logging_fix branch February 8, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants