-
Notifications
You must be signed in to change notification settings - Fork 1
Rewrite parts of theme61 to use S3 methods #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aaronw22
wants to merge
65
commits into
dev
Choose a base branch
from
s3-rewrite
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # man/setup_stadia_maps.Rd
# Conflicts: # man/setup_stadia_maps.Rd # tests/testthat/test-theme_e61.R
…vide them by default. Also changed the implementation for manual facet label position selection to be more streamlined.
…h a S3 method that calls at build time so that all the axes are detected regardless of how/where y = is defined + add tests" This reverts commit 91f0d04.
…ot() with a S3 method that calls at build time so that all the axes are detected regardless of how/where y = is defined + add tests"" This reverts commit d0c8fb3.
…thod that calls at build time so that all the axes are detected regardless of how/where y = is defined + add tests
…into s3-rewrite # Conflicts: # DESCRIPTION
# Conflicts: # R/ggplot_build-method.R # R/print-e61-ggplot.R # R/save-helpers.R # man/print.e61_plot.Rd
# Conflicts: # DESCRIPTION # NAMESPACE # R/plot_label.R # man/plot_label.Rd # tests/testthat/test-plot_label.R
# Conflicts: # DESCRIPTION # NAMESPACE # R/ggplot2-wrappers.R # R/ggplot_build-method.R # R/print-e61-ggplot.R # R/save-helpers.R # tests/testthat/test-ggplot2-wrappers.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do list
as_e61_plot()S3 genericggplote61_plot(idempotent)patchwork,listtheme61::ggplot()andsave_e61()callas_e61_plot()Introduce plot classes:
e61_plote61_map(inherits frome61_plot)Decide classification strategy:
as_e61_map()), orRemove repeated
if (is_spatial(...))logic where possiblee61_prepare(plot, ...)e61_plot_dims(plot, ...)e61_prepare.e61_plote61_prepare.e61_mapsave_e61(),save_single(),save_multi()to call these generics instead of branching inlineggplot_add()plot_label()add_baseline()add_e61_logo()geom_pointbar()aes_y_lims(),aes_labs(),labs_e61()ggplot_add.<spec_class>()methodse61_plotvse61_maptheme_e61()and spatial theme logictheme_e61()return ane61_themespec objectggplot_add.e61_theme()that:e61_plote61_maptheme_e61_spatial()as a thin wrapper that just tags the plot as a mape61_y_scale,e61_secondary_axis)scales.Rsec_axes_rescale.Rsave_e61()e61_save_resultclassprint.e61_save_result()as.character.e61_save_result()knit_print.e61_save_result()Describe your changes
Do the following before requesting a review
For feature branches
_pkgdown.ymlfile.devtools::document().DESCRIPTIONwith any new package dependencies.Additional steps for the last PR into dev prior to releasing a new version from dev to main
DESCRIPTIONwith the new package version number.NEWS.mdwith a brief description of my changes._pkgdown.ymlfile is correctly built by runningpkgdown::check_pkgdown().devtools::build_readme()to updateREADME.md.pkgdown::build_site_github_pages().