The viewer doesn't display free scales with facet_wrap

[NickG-e61]

It seems to default to auto_scale = TRUE, which makes a lot of multi-facet graphs unreadable.

Then when saving the graph with save_e61() and auto_scale = FALSE, it looks how it's meant to.

Could we just set the default value of auto_scale to FALSE? I don't think I've used TRUE once.

Minor bug because it's only a minor inconvenience to save it and look at the viewer then, but it seems to defeat the purpose a bit of updating the viewer function.

[aaronw22]

It seems to default to auto_scale = TRUE, which makes a lot of multi-facet graphs unreadable.

That is definitely annoying behaviour, although that is partly the fault of ggplot2 not having options to manually determine the scales of individual facet panels. I could look into having save_e61 detect whether free scales have been set in facet_wrap before deciding whether to run the autoscaling code by default.

Could we just set the default value of auto_scale to FALSE? I don't think I've used TRUE once.

That would defeat the purpose of having auto scaling for everyone else.

Also, the code behind auto_scale only runs if you haven't specified y-axis limits in scale_y_continuous_e61. So, if you are actually setting auto_scale = F every time, then you might be calling it unnecessarily frequently for single-panel graphs, or you only make facet panel graphs where this issue comes up?

[NickG-e61]

"That would defeat the purpose of having auto scaling for everyone else."

My point was that maybe my experiences are not completely unrepresentative.

"then you might be calling it unnecessarily frequently for single-panel graphs, or you only make facet panel graphs where this issue comes up?"

Not sure I fully understand, but I rarely use scale_y_continuous_e61 if that answers the question.

[JackBuckley]

As Aaron suggests, I think having save_e61 detect whether free scales have been set before deciding whether to auto scale the y-axis or not will solve this issue.

The principle of auto scale is that creates a sensible and asethetic default scale when the user has not provided their own scales through either scale_y_continuous, or scale_y_continuous_e61. As Aaron notes, ggplot doesn't allow user provided scales for specific facets so this doesn't work well with facetted plots with free scales. And because setting scales = "free" or "free_y" is effectively the user deliverately setting scales this seems like a good thing to pick up when deciding whether to run auto scale.