Threads controller UI and removing attachments #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KamilaHasanbega
commented
Aug 24, 2016
KamilaHasanbega
commented
- Fixed UI for the threads controller.
- Addressed the issue Removing attachments bug #27 regarding removing attachments.
Added the two introductory pages, “Introduction” & “Get Started” and their controllers/design. Fixed the flow to redirect to the first page when setting up, and from them to the Welcome page.
Added the case in which the user is Logged in but does not have authorizations. Fixed the flow accordingly. Fixed the design of the rest.
…' of https://github.com/KamilaHasanbega/e2email into show-attachments
…/e2email into show-attachments
added 11 commits
August 17, 2016 21:06
| @@ -159,6 +159,77 @@ div.big-icon > img { | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| .attach-icon { | |||
There was a problem hiding this comment.
Why are attachment-specific definitions needed in app.css? Do they need to be shared across pages?
There was a problem hiding this comment.
The CSS for the attachment icon and attachment input/display is in two pages: Threads.html and Messages.html, I put it on app.css not to have repetitive code.
| <div ng-repeat="x in threadsCtrl.compose.attachments" class="single-attachment">{{x.filename + ' (' + x.size + 'K)'}}</div> | ||
| </div> | ||
| <div ng-repeat="x in threadsCtrl.compose.attachments" class="single-attachment"><span id="attachName">{{ x.filename | limitTo: 20 }}{{x.filename.length > 20 ? '...' : ''}} </span> <span id="attachSize"> {{'(' + x.size + ')'}} </span> <span style="width:10%;"> | ||
| <button ng-click="threadsCtrl.removeObj($index" class="removeAttachment"> x </button> </span></div> |
|
OK to merge @kbsriram |
|
Rebased via a962299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.